Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12177 )
Change subject: make gsup ipa name configurable in osmo-msc.cfg ...................................................................... Patch Set 6: Code-Review+2 (2 comments) nice! maybe fix that space first https://gerrit.osmocom.org/#/c/12177/6/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12177/6/src/libvlr/vlr.c@1217 PS6, Line 1217: const char *gsup_server_addr_str, uint16_t gsup_server_port) (still got the space indent here from the earlier patch set) https://gerrit.osmocom.org/#/c/12177/6/tests/msc_vlr/msc_vlr_tests.c File tests/msc_vlr/msc_vlr_tests.c: https://gerrit.osmocom.org/#/c/12177/6/tests/msc_vlr/msc_vlr_tests.c@556 PS6, Line 556: struct osmo_oap_client_config *oap_config) (for some reason gerrit shows indenting changes above?) (when I wrote this, it should have lined up with '(' ... we could fix that now) -- To view, visit https://gerrit.osmocom.org/12177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 10:59:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
