Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 )
Change subject: Use libosmocore constant for IMSI length in ACL entry ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h@417 PS2, Line 417: char imsi[GSM23003_IMSI_MAX_DIGITS + 2]; > > And in there we use +1, which makes more sense […] So commit openbsc d3fa84dbba3b67cdbe2d8c789b2833b5ddf42068 changed GSM_IMSI_LENGTH to be GSM23003_IMSI_MAX_DIGITS+1 in all places except one to GSM23003_IMSI_MAX_DIGITS+2. That looks like a typo in that commit to me. @Harald, can you confirm (you are the author of the commit)? -- To view, visit https://gerrit.osmocom.org/12224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138aea409aab0c748c75546e628797fc7498bf40 Gerrit-Change-Number: 12224 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Dec 2018 17:57:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
