Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12234 )
Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12234/2/src/libvlr/vlr_lu_fsm.c File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/#/c/12234/2/src/libvlr/vlr_lu_fsm.c@274 PS2, Line 274: /* THIS IS CURRENTLY DEAD CODE, SINCE WE NEVER SET vsub->ms_not_reachable_flag = true. Probably also good to state the same in the callers. -- To view, visit https://gerrit.osmocom.org/12234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I198d442e9ed288f37c7d4e5ec87b82dc53114e99 Gerrit-Change-Number: 12234 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 11:38:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
