Max has posted comments on this change. ( https://gerrit.osmocom.org/12234 )
Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12234/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12234/3//COMMIT_MSG@18 PS3, Line 18: this models some FSM definition from 3GPP specs, and we have a couple other It would be better to add actual spec reference here as well as in the comment. -- To view, visit https://gerrit.osmocom.org/12234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I198d442e9ed288f37c7d4e5ec87b82dc53114e99 Gerrit-Change-Number: 12234 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 14 Dec 2018 12:57:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
