Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11924 )
Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/11924/4/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/#/c/11924/4/msc/MSC_Tests.ttcn@2158
PS4, Line 2158: sm_rp_da :=
valueof(ts_GSUP_SM_RP_DA_MSISDN(g_pars.msisdn)),
I still had reservations about OA,DA encoding in that libosmocore patch...
--
To view, visit https://gerrit.osmocom.org/11924
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f
Gerrit-Change-Number: 11924
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-CC: Holger Freyther <[email protected]>
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
