Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11924 )
Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err} ...................................................................... Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/11924/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11924/5//COMMIT_MSG@10 PS5, Line 10: initiated by ESME over GSUP. Basically, the algorythm is spelling: "algorithm" https://gerrit.osmocom.org/#/c/11924/5/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11924/5/msc/MSC_Tests.ttcn@2160 PS5, Line 2160: sm_rp_ui := '00068021436500008111328130858200'O, What information is encoded in this string? It might be obvious to those familiar with the data structures involved, but a comment here could help readers who are unfamiliar with them. -- To view, visit https://gerrit.osmocom.org/11924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f Gerrit-Change-Number: 11924 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Holger Freyther <hol...@freyther.de> Gerrit-Comment-Date: Mon, 17 Dec 2018 11:05:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes