Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 )
Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1093 PS5, Line 1093: relay sub-layer protocol. It can be either of the following: "Either" implies that there are only two options. Since there are three options listed below, this should say "any of the following" instead of "either of the following". https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1106 PS5, Line 1106: relay sub-layer protocol. It can be either of the following: Here, "either" is fine :) https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1168 PS5, Line 1168: should keep RAN the connection open. See 3GPP TS 29.002, section 7.6.8.7. I'm having trouble understanding this part: "the network should keep RAN the connection open" Did you mean to write "the network should keep the RAN connection open" instead? Or something else? -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Fri, 14 Dec 2018 12:27:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
