Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 )
Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages ...................................................................... Patch Set 6: Code-Review+1 (1 comment) got a comment still, but since it's minor... https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc@1134 PS6, Line 1134: |0x00|Reserved (used inside libosmocore only) Leaking implementation details into the protocol specification. To guard 0x00 in libosmocore is a detail of how libosmocore handles presence flagging, does not belong here. Reserving should make sense from a protocol perspective, e.g.: "Reserved for future extension"? Or you could say just "Reserved" without a reason... -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 17 Dec 2018 14:52:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
