Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 7: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/11992/7/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/#/c/11992/7/include/osmocom/msc/gsm_data.h@188 PS7, Line 188: int ncss_guard_timeout; Why do you use int in here? https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c File src/libmsc/gsm_09_11.c: https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c@141 PS7, Line 141: /* Init self-destruction timer */ That sounds ominous - I like it :) https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c@477 PS7, Line 477: if (net->ncss_guard_timeout > 0) { Seems like we always check ncss_guard_timeout > 0 https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/msc_vty.c@382 PS7, Line 382: "guard timer value (sec.), or 0 to disable\n") So ncss_guard_timeout is always positive and fit into uint8_t. -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 14 Dec 2018 13:14:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes