Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c File src/libmsc/gsm_09_11.c: https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c@62 PS7, Line 62: /* Release connection (if any) with subscriber */ There is a comment elsewhere in this file, above another call to trans_free(trans) which says: /* TODO: release connection with subscriber */ It looks like a general cleanup function might be useful, which could be invoked from this timeout handler and from other places? Perhaps not in this patch, but in a future patch? -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 17 Dec 2018 10:58:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
