Vadim Yanitskiy has submitted this change and it was merged. (
https://gerrit.osmocom.org/12324 )
Change subject: trx_toolkit/burst_send.py: exit if DATA dump parsing failed
......................................................................
trx_toolkit/burst_send.py: exit if DATA dump parsing failed
False is not iterable, so we should properly handle the case
when parsing of the whole DATA dump was failed (e.g. due to
incorrect offset specified).
Change-Id: I5443efb39bb9d3377290ce7ec5e34016cae0edb2
---
M src/target/trx_toolkit/burst_send.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/target/trx_toolkit/burst_send.py
b/src/target/trx_toolkit/burst_send.py
index 7186863..6c19e6f 100755
--- a/src/target/trx_toolkit/burst_send.py
+++ b/src/target/trx_toolkit/burst_send.py
@@ -63,7 +63,8 @@
messages = self.ddf.parse_all(
skip = self.argv.cnt_skip, count = self.argv.cnt_count)
if messages is False:
- pass # FIXME!!!
+ log.error("Parsing failed, nothing to send")
+ sys.exit(1)
for msg in messages:
# Pass filter
--
To view, visit https://gerrit.osmocom.org/12324
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5443efb39bb9d3377290ce7ec5e34016cae0edb2
Gerrit-Change-Number: 12324
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
