Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12329 )
Change subject: MNCC: use log wrapper for call processing ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12329/1/src/libmsc/mncc_builtin.c File src/libmsc/mncc_builtin.c: https://gerrit.osmocom.org/#/c/12329/1/src/libmsc/mncc_builtin.c@38 PS1, Line 38: #define DEBUGCC(ss, l, r, fmt, args...) DEBUGP(ss, "(call %x, remote %x) " fmt "\n", l->callref, r->callref, ##args) No need to pass DMNCC everywhere. Since the define is local to the file, move DMNCC here and remove it from all changed lines. https://gerrit.osmocom.org/#/c/12329/1/src/libmsc/mncc_builtin.c@39 PS1, Line 39: #define LOGCC(ss, ll, l, r, fmt, args...) LOGP(ss, ll, "(call %x, remote %x) " fmt "\n", l->callref, r->callref, ##args) This one is not used here, remove it. -- To view, visit https://gerrit.osmocom.org/12329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c44d7bb28f1ff895dd4f839d75840495503c916 Gerrit-Change-Number: 12329 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 17 Dec 2018 13:12:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
