Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12329 )
Change subject: MNCC: use log wrapper for call processing ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12329/3/src/libmsc/mncc_builtin.c File src/libmsc/mncc_builtin.c: https://gerrit.osmocom.org/#/c/12329/3/src/libmsc/mncc_builtin.c@38 PS3, Line 38: "\n" Can you show me any examples in existing osmocom code where a log/debug helper macro prints the \n, rather than the caller/user of that macro? I don't think so, but feel free to prove me wrong. Intorducing this kind of inconsistency across programs/macros makes work harder for developers for no good reason. -- To view, visit https://gerrit.osmocom.org/12329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c44d7bb28f1ff895dd4f839d75840495503c916 Gerrit-Change-Number: 12329 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 16:49:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
