Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12355 )
Change subject: mgcp_client_vty: fix missing talloc_free ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12355/1/src/libosmo-mgcp-client/mgcp_client_vty.c File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/#/c/12355/1/src/libosmo-mgcp-client/mgcp_client_vty.c@46 PS1, Line 46: if (global_mgcp_client_conf->local_addr) osmo_talloc_replace_string(global_mgcp_client_ctx, &global_mgcp_client_conf->local_addr, argv[0]); https://gerrit.osmocom.org/#/c/12355/1/src/libosmo-mgcp-client/mgcp_client_vty.c@80 PS1, Line 80: if (global_mgcp_client_conf->remote_addr) Same, see osmo_talloc_replace_string. -- To view, visit https://gerrit.osmocom.org/12355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409 Gerrit-Change-Number: 12355 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 12:02:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
