Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12355 )
Change subject: mgcp_client_vty: fix missing talloc_free ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c@47 PS2, Line 47: (char**)&global_mgcp_client_conf->local_addr, > Probably, 'const char *' vs 'char *'? yea the struct defines it as const, and that won't go with talloc. It should have been a char[] from the start, but probably not worth the trouble to change that -- To view, visit https://gerrit.osmocom.org/12355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409 Gerrit-Change-Number: 12355 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 18:38:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
