Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12368 )
Change subject: abort assignment on Assignment Failure ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085 PS3, Line 1085: conn->fi->id); Why not 'LOGPFSM(conn->fi, ...);'? https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/osmo_msc.c File src/libmsc/osmo_msc.c: https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/osmo_msc.c@127 PS3, Line 127: LOGP Same, LOGPFSM()? -- To view, visit https://gerrit.osmocom.org/12368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a Gerrit-Change-Number: 12368 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 20:39:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
