Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12368 )
Change subject: abort assignment on Assignment Failure ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Code looks good, logging is not critical. https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085 PS3, Line 1085: conn->fi->id); > Maybe we also need LOGPFSMSL(FI, SUBSYS, LEVEL, fmt, args)? I like this idea. -- To view, visit https://gerrit.osmocom.org/12368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a Gerrit-Change-Number: 12368 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 23:04:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
