Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12297 )

Change subject: mgw: Tear down all RTP flows to avoid race condition on tear 
down
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12297/1/mgw/MGCP_Test.ttcn
File mgw/MGCP_Test.ttcn:

https://gerrit.osmocom.org/#/c/12297/1/mgw/MGCP_Test.ttcn@1215
PS1, Line 1215:                 f_rtpem_mode(RTPEM[2], RTPEM_MODE_NONE);
> I'm kinda confused by this: why do we have to do this for RTPEM[2] but not 
> for 0 and 1? And where do […]
It is done for RTPEM[0] and RTPEM[1], inside f_flow_delete().



--
To view, visit https://gerrit.osmocom.org/12297
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied839596589609e75fa487046a85db48991e4c73
Gerrit-Change-Number: 12297
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Thu, 20 Dec 2018 17:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to