Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/12297 )
Change subject: mgw: Tear down all RTP flows to avoid race condition on tear
down
......................................................................
mgw: Tear down all RTP flows to avoid race condition on tear down
When stopping the test TC_two_crcx_and_unsolicited_rtp the unsolicited
RTP stream is not stopped. As a result it could happen that between
tearing down the other flows and stopping the test an unsolicited RTP
packet is sent to a closed socket.
The resulting ICMP destination unreachable packet translates to a
"Connection refused" error on the sending socket and fails the test.
Avoid this by making sure the unsolicited RTP sender is stopped before
stopping the test.
Change-Id: Ied839596589609e75fa487046a85db48991e4c73
---
M mgw/MGCP_Test.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Stefan Sperling: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index e1ebc26..9adeb2a 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1211,6 +1211,8 @@
f_sleep(0.5);
+ /* Stop transmitting packets and tear down the flows */
+ f_rtpem_mode(RTPEM[2], RTPEM_MODE_NONE);
f_flow_delete(RTPEM[0]);
f_flow_delete(RTPEM[1], ep, call_id);
--
To view, visit https://gerrit.osmocom.org/12297
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied839596589609e75fa487046a85db48991e4c73
Gerrit-Change-Number: 12297
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
