Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12402
Change subject: enrich context for vlr_subscr_name and ran_conn fi name ...................................................................... enrich context for vlr_subscr_name and ran_conn fi name Include all available information in vlr_subscr_name(); instead of either IMSI or MSISDN or TMSI, print all of them when present. Instead of a short log, rather have more valuable context. A context info would now look like: Process_Access_Request_VLR(GERAN-A-3_IMSI-901700000014706_MSISDN-2023_TMSI-0x08bde4ec_PAGING_RESP) It does get quite long, but ensures easy correlation of any BSSAP / IuCS messages with log output, especially if multiple subscribers are busy at the same time. When showing the RAN conn id, instead of GERAN_A-00000017 write GERAN-A-23 - We usually write the conn_id in decimal. - Leading zeros are clutter. - Don't mix - and _ separators. These changes are combined to produce only one burst of humungous amounts of msc_vlr_tests expected output. That is definitely a weak point of these tests: blowing up the git history. OTOH they do show logging changes nicely. Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 --- M include/osmocom/msc/ran_conn.h M src/libmsc/gsm_04_08.c M src/libmsc/ran_conn.c M src/libvlr/vlr.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err 16 files changed, 11,382 insertions(+), 11,142 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/12402/1 -- To view, visit https://gerrit.osmocom.org/12402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]>
