Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12402 )
Change subject: enrich context for vlr_subscr_name and ran_conn fi name ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/12402/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12402/1//COMMIT_MSG@15 PS1, Line 15: 0x08bde4ec TMSIs are typically (in the telecom world) represented as uppercase hex digits. I know in Osmocom we're not aligning well with that, but we could start... https://gerrit.osmocom.org/#/c/12402/1//COMMIT_MSG@29 PS1, Line 29: We usually write the conn_id in decimal ack https://gerrit.osmocom.org/#/c/12402/1//COMMIT_MSG@30 PS1, Line 30: Leading zeros are clutter well, the only reson to use them would be to align log output of multiple lines at the same column, which of course only works if you don't pront file name / line numbers. So I'd say there are arguments either way. https://gerrit.osmocom.org/#/c/12402/1//COMMIT_MSG@31 PS1, Line 31: Don't mix - and _ separators I would argue that the existing behavior is a feature. GERAN_A is the label/name/class/type of connection and the "-" is seprating it from the connection id -- To view, visit https://gerrit.osmocom.org/12402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Sun, 23 Dec 2018 10:04:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
