Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12409 )
Change subject: GSUP: add CHECK-IMEI message ...................................................................... Patch Set 2: (1 comment) Please also update osmo-gsm-manuals. https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h@277 PS2, Line 277: osmo_gsup_imei_result You are basically introducing three types: OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, OSMO_GSUP_MSGT_CHECK_IMEI_ERROR (NACK), OSMO_GSUP_MSGT_CHECK_IMEI_RESULT (ACK), so I don't think we need this IE. Probably, I am not getting the meaning of ACK/NACK? -- To view, visit https://gerrit.osmocom.org/12409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I085819df0ea7f3bfeb0cabebb5fd1942a23c6155 Gerrit-Change-Number: 12409 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 21 Dec 2018 11:52:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
