osmith has posted comments on this change. ( https://gerrit.osmocom.org/12409 )
Change subject: GSUP: add CHECK-IMEI message ...................................................................... Patch Set 2: (1 comment) > Please also update osmo-gsm-manuals. Yes, I have it as checklist item in the issue: https://osmocom.org/issues/3733 https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h@277 PS2, Line 277: osmo_gsup_imei_result > You are basically introducing three types: […] The response to CHECK_IMEI could be, as intended by the standard: * ACK: this IMEI is okay, allow it to be used * NACK: this IMEI is not allowed to be used (e.g. because it is on a stolen device blacklist) We don't check against a blacklist or whitelist in the Osmocom stack, and this is not planned IIRC. Right now, always ACK is sent back. But this could come in the future, so having the option to say ACK or NACK here is closer to the spec. ERROR is sent back when the IMEI can not be decoded. See also the related HLR changes using this message: https://gerrit.osmocom.org/#/c/osmo-hlr/+/12411/1/src/hlr.c -- To view, visit https://gerrit.osmocom.org/12409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I085819df0ea7f3bfeb0cabebb5fd1942a23c6155 Gerrit-Change-Number: 12409 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 21 Dec 2018 12:30:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
