Max has posted comments on this change. ( https://gerrit.osmocom.org/12447 )
Change subject: Constify trans_assign_trans_id() parameters ...................................................................... Patch Set 1: > Why do we need this change? Which problems it would solve? It makes reading code easier because this patch makes it obvious from the function signature that function does not change its parameters without the need to read entire function. -- To view, visit https://gerrit.osmocom.org/12447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae Gerrit-Change-Number: 12447 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 02 Jan 2019 11:39:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
