Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12447 )
Change subject: Constify transaction helpers parameters
......................................................................
Constify transaction helpers parameters
Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae
---
M include/osmocom/msc/transaction.h
M src/libmsc/transaction.c
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/msc/transaction.h
b/include/osmocom/msc/transaction.h
index 0760c07..e82f0a5 100644
--- a/include/osmocom/msc/transaction.h
+++ b/include/osmocom/msc/transaction.h
@@ -98,11 +98,11 @@
-struct gsm_trans *trans_find_by_id(struct ran_conn *conn,
+struct gsm_trans *trans_find_by_id(const struct ran_conn *conn,
uint8_t proto, uint8_t trans_id);
-struct gsm_trans *trans_find_by_callref(struct gsm_network *net,
+struct gsm_trans *trans_find_by_callref(const struct gsm_network *net,
uint32_t callref);
-struct gsm_trans *trans_find_by_sm_rp_mr(struct ran_conn *conn,
+struct gsm_trans *trans_find_by_sm_rp_mr(const struct ran_conn *conn,
uint8_t sm_rp_mr);
struct gsm_trans *trans_alloc(struct gsm_network *net,
@@ -111,9 +111,9 @@
uint32_t callref);
void trans_free(struct gsm_trans *trans);
-int trans_assign_trans_id(struct gsm_network *net, struct vlr_subscr *vsub,
+int trans_assign_trans_id(const struct gsm_network *net, const struct
vlr_subscr *vsub,
uint8_t protocol, uint8_t ti_flag);
struct gsm_trans *trans_has_conn(const struct ran_conn *conn);
-void trans_conn_closed(struct ran_conn *conn);
+void trans_conn_closed(const struct ran_conn *conn);
#endif
diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index a0f7b31..f62d6b4 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -38,7 +38,7 @@
* \param[in] trans_id Transaction ID of transaction
* \returns Matching transaction, if any
*/
-struct gsm_trans *trans_find_by_id(struct ran_conn *conn,
+struct gsm_trans *trans_find_by_id(const struct ran_conn *conn,
uint8_t proto, uint8_t trans_id)
{
struct gsm_trans *trans;
@@ -59,7 +59,7 @@
* \param[in] callref Call Reference of transaction
* \returns Matching transaction, if any
*/
-struct gsm_trans *trans_find_by_callref(struct gsm_network *net,
+struct gsm_trans *trans_find_by_callref(const struct gsm_network *net,
uint32_t callref)
{
struct gsm_trans *trans;
@@ -76,7 +76,7 @@
* \param[in] sm_rp_mr RP Message Reference (see GSM TS 04.11, section 8.2.3)
* \returns Matching transaction, NULL otherwise
*/
-struct gsm_trans *trans_find_by_sm_rp_mr(struct ran_conn *conn,
+struct gsm_trans *trans_find_by_sm_rp_mr(const struct ran_conn *conn,
uint8_t sm_rp_mr)
{
struct gsm_network *net = conn->network;
@@ -182,7 +182,7 @@
* \param[in] protocol Protocol for whihc to find ID
* \param[in] ti_flag FIXME
*/
-int trans_assign_trans_id(struct gsm_network *net, struct vlr_subscr *vsub,
+int trans_assign_trans_id(const struct gsm_network *net, const struct
vlr_subscr *vsub,
uint8_t protocol, uint8_t ti_flag)
{
struct gsm_trans *trans;
@@ -234,7 +234,7 @@
* facilities, which will then send the necessary release indications.
* \param[in] conn Connection that is going to be closed.
*/
-void trans_conn_closed(struct ran_conn *conn)
+void trans_conn_closed(const struct ran_conn *conn)
{
struct gsm_trans *trans;
--
To view, visit https://gerrit.osmocom.org/12447
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae
Gerrit-Change-Number: 12447
Gerrit-PatchSet: 3
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
