Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12457 )
Change subject: mncc socket: add field ran ...................................................................... Patch Set 2: Code-Review-1 What I'm missing here is some kind of description on why it is added and for what it is intended to be used. Normally, a MNCC peer should not care about what kind of RAT is used. Also, the RAT can change at any time, even multiple times during a call. So in general, I would avoid falling into the same trap as we did when "lchan" information was added to MNCC. Call Control should not care about this and should live on a much higher layer. So please let's state explicitly why it is added and what it's used for before taking any decisions on merging this. Also, any change to the layout of MNCC should bump the related version, shouldn't it? -- To view, visit https://gerrit.osmocom.org/12457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f28dbca1b515f9eaa6a8708a7ccfa1eb6f6b6cc Gerrit-Change-Number: 12457 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 10:26:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
