Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/10185/8/include/osmocom/gsm/gsm48_arfcn_range_encode.h File include/osmocom/gsm/gsm48_arfcn_range_encode.h: https://gerrit.osmocom.org/#/c/10185/8/include/osmocom/gsm/gsm48_arfcn_range_encode.h@22 PS8, Line 22: int osmo_gsm48_range_enc_range128(uint8_t *chan_list, int f0, int *w); > I think single "range" in function name is enough - it's already pretty long. Fixed in next patch set. https://gerrit.osmocom.org/#/c/10185/8/src/gsm/gsm48_arfcn_range_encode.c File src/gsm/gsm48_arfcn_range_encode.c: https://gerrit.osmocom.org/#/c/10185/8/src/gsm/gsm48_arfcn_range_encode.c@54 PS8, Line 54: */ > Can we use this as static function? In OsmoBSC it's called only once from > _range_enc_arfcns() No this function cannot be static because it is also being called from gsm0408_test.c, which can only link to exported symbols. https://gerrit.osmocom.org/#/c/10185/8/src/gsm/gsm48_arfcn_range_encode.c@302 PS8, Line 302: { > This helper is used only in range_encode() in OsmoBSC which is static in this > patch. […] This is being called by test code as well. -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-CC: Holger Freyther <hol...@freyther.de> Gerrit-Comment-Date: Mon, 07 Jan 2019 12:01:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
