Max has posted comments on this change. ( https://gerrit.osmocom.org/10185 )

Change subject: port arfcn range encode support from osmo-bsc
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/#/c/10185/8/include/osmocom/gsm/gsm48_arfcn_range_encode.h
File include/osmocom/gsm/gsm48_arfcn_range_encode.h:

https://gerrit.osmocom.org/#/c/10185/8/include/osmocom/gsm/gsm48_arfcn_range_encode.h@22
PS8, Line 22: int osmo_gsm48_range_enc_range128(uint8_t *chan_list, int f0, int 
*w);
I think single "range" in function name is enough - it's already pretty long.



--
To view, visit https://gerrit.osmocom.org/10185
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c
Gerrit-Change-Number: 10185
Gerrit-PatchSet: 8
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-CC: Holger Freyther <[email protected]>
Gerrit-Comment-Date: Wed, 02 Jan 2019 09:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to