Max has posted comments on this change. ( https://gerrit.osmocom.org/12375 )
Change subject: LCLS: don't encode incorrect values ...................................................................... Patch Set 2: (1 comment) Addressed in latest revision. https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c@340 PS1, Line 340: if (status >= GSM0808_LCLS_STS_NA) > I'm not sure this is worth it. […] Done -- To view, visit https://gerrit.osmocom.org/12375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59 Gerrit-Change-Number: 12375 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 12:51:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
