Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12375 )
Change subject: LCLS: don't encode incorrect values ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12375/3/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12375/3/src/gsm/gsm0808.c@346 PS3, Line 346: return NULL; Have you seen a situation where these values were wrong / do they come from rx'ing packets? If these are directly called with enum constants from our code, I wouldn't bother to check them. If keeping the check: - enums can also have negative values. - what about the enum values in-between ST_LOCALLY_SWITCHED and _NA. -- To view, visit https://gerrit.osmocom.org/12375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59 Gerrit-Change-Number: 12375 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:22:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
