Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 29: (10 comments) https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@597 PS29, Line 597: if (type_ie[0] == SGSAP_ID_NONEPS_T_EXPLICIT_UE_NONEPS) (a switch() would be nicer here) https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@624 PS29, Line 624: if (type_ie[0] == SGSAP_ID_EPS_T_NETWORK_INITIATED) (a switch() would be nicer here) https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@650 PS29, Line 650: /* Subscriber must be known by the HLR */ VLR != HLR https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@655 PS29, Line 655: /* Inform the HLR */ AFAICT this is not sending anything to the HLR https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@708 PS29, Line 708: * is comparable to a paging response. The SGsAP SERVICE REQUEST must so an SGsAP Service Request is a reply to an earlier message from the 2G CN? https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@772 PS29, Line 772: conn = connection_for_subscr(vsub); is it possible that we obtain a conn that was established on GSM and not via SGs? A subscriber could be active on 2G, lose that connection, and while that is in timeout, some LTE action starts. Not sure where that should happen, but would it make sense to make sure that when establishing SGs for a subscriber, that any previous 2G/3G connections are discarded? https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@1140 PS29, Line 1140: /*! This function expects a pointer to the related gsm subscriber inline comment rather without doxygen marker https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c@1212 PS29, Line 1212: osmo_fsm_register(&sgs_vlr_reset_fsm); register sgs_ue_fsm? https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c File src/libvlr/vlr_sgs.c: https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c@205 PS29, Line 205: /*! Perform an SGs TMSI reallocation complete. wrong comment https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c@226 PS29, Line 226: /*! Notify that an SGs paging has been rejected by the MME. wrong comment -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 29 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:13:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
