Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 30: (1 comment) https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c@564 PS30, Line 564: conn->via_ran == OSMO_RAT_UTRAN_IU ? "Iu" : "A", > here maybe rather use osmo_rat_type_name(), otherwise all SGs conns are shown > as "A". (BTW, for the inter-MSC stuff, this will have to change anyway, so it's enough to solve it trivially / quickly and not spend much time on it.) -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 30 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 21 Jan 2019 01:45:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
