Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper ...................................................................... Patch Set 1: Code-Review-1 (1 comment) good except https://gerrit.osmocom.org/#/c/12493/1/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12493/1/tests/gsm0808/gsm0808_test.c@735 PS1, Line 735: } The two above seem to make sense, but they are functional changes unrelated to the comparison function. Please move to a separate patch. -- To view, visit https://gerrit.osmocom.org/12493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984 Gerrit-Change-Number: 12493 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:58:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
