Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12470 )

Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12470/2/include/osmocom/msc/ran_conn.h
File include/osmocom/msc/ran_conn.h:

https://gerrit.osmocom.org/#/c/12470/2/include/osmocom/msc/ran_conn.h@11
PS2, Line 11: LOG_RAN_CONN
As far as I can see, all other logging macros are using 'LOGP' prefix. Why it 
isn't used here?



--
To view, visit https://gerrit.osmocom.org/12470
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a
Gerrit-Change-Number: 12470
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-CC: Max <[email protected]>
Gerrit-Comment-Date: Thu, 10 Jan 2019 12:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to