Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 )
Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context ...................................................................... Patch Set 4: > Patch Set 4: > > was there any feedback yet to my question raised on January 7: > "Doesn't every RAN connection have a fsm instance? why not simply log > through that FSM and use that FSMs log level / subsystem?" Sorry, missed that comment. The useful part is to use the ran_conn->fi's id as context info. FI's log level: the FI's log level is more about the level on which to see the FSM transitions. If I LOG_RAN_CONN(LOGL_ERROR), I want to log it as error, not as debug, just because the FI is on debug. FSM's subsys: a ran_conn has various stuff happening: BSSMAP, RANAP, CC, SMS, USSD, MM, RR, ... and so far a lot of logging uses the conn's (so far vsub) context as logging context info. If we used the FSM's logging subsys for all of those, then we would substantially flatten the use of logging categories. In the end all that we need from the FI is its logging context. But I realize that I can indeed use LOGPFSMSL() with identical features, in next patch set. -- To view, visit https://gerrit.osmocom.org/12470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a Gerrit-Change-Number: 12470 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jan 2019 17:48:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
