osmith has posted comments on this change. ( https://gerrit.osmocom.org/12478 )

Change subject: VLR: send CHECK-IMEI to EIR/HLR
......................................................................


Patch Set 7:

Thanks for the review!

> maybe drop the FIXME from vlr_lu_fsm.c:506?

I am not what it means, therefore I am not sure if it can be dropped:
> /* FIXME: IMEI Check Fail to VLR Application (Detach IMSI VLR) */

(According to the git log, that FIXME is from the big "add libvlr 
implementation" commit from you and Harald.)


--
To view, visit https://gerrit.osmocom.org/12478
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 10 Jan 2019 12:42:44 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to