Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12478 )

Change subject: VLR: send CHECK-IMEI to EIR/HLR
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr_lu_fsm.c
File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr_lu_fsm.c@1234
PS8, Line 1234: vlr_subscr_tx_req_check_imei
Should we still do this if check-imei-req is disabled in the VTY config?


https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr_lu_fsm.c@1242
PS8, Line 1242: NULL
Wait, vlr_subscr_handle_check_imei() is passing the cause here, but we don't 
use it?



--
To view, visit https://gerrit.osmocom.org/12478
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 8
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 11 Jan 2019 14:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to