Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: transaction: drop unused ti_flag ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: Code-Review-2 Could you please clarify why it's better to keep ti_flag parameter? Would be nice to add comment regarding the intention behind this variable or how it might be used in future. https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG@10 PS1, Line 10: unused > Actually, it's used, but '0'B is always passed. That's what I meant by "unused" - the variable is there but it's value always the same. -- To view, visit https://gerrit.osmocom.org/12519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie11999900b1789652ee078d34636dcda1e137eb0 Gerrit-Change-Number: 12519 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 14 Jan 2019 10:19:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
