Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: Clarify transaction ID assignment ...................................................................... Patch Set 4: Hmm, > We can add another patch on top of latest revision which drops > this parameter - should be trivial merge of wrapper into function. since we I've decided to get rid of this flag, I don't see any benefits of clarifying its meaning and adding additional wrappers, TBH. -- To view, visit https://gerrit.osmocom.org/12519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie11999900b1789652ee078d34636dcda1e137eb0 Gerrit-Change-Number: 12519 Gerrit-PatchSet: 4 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 13:25:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
