Max has posted comments on this change. ( https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/11504/7/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/7/src/gsm/gsm0808_utils.c@1450
PS7, Line 1450:                              bool exact_match)
Is there any use-case where this would be called directly instead of 
gsm0808_cell_ids_match() and gsm0808_cell_id_matches_list()? If not than we can 
make this static as well.



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-CC: Stefan Sperling <s...@stsp.name>
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to