Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 )
Change subject: gsm0808: add BSSMAP Cell Identifier matching API ...................................................................... Patch Set 9: (4 comments) https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm0808_utils.c@1373 PS9, Line 1373: gsm0808_cell_id_u_name > Are there any users of this function outside the library? […] oh, wait what, I thought I was adding this function. https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c File src/gsm/gsm23003.c: https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c@339 PS9, Line 339: a->lac > b->lac > If not a < b, and not a > b, then a != b, right? please read your comment and the code again :) https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c@356 PS9, Line 356: a->cell_identity > b->cell_identity > same here. :) https://gerrit.osmocom.org/#/c/11504/9/src/gsm/libosmogsm.map File src/gsm/libosmogsm.map: https://gerrit.osmocom.org/#/c/11504/9/src/gsm/libosmogsm.map@213 PS9, Line 213: gsm0808_cell_id_u_match > So, you're making this symbol static, thus breaking the API, but still > keeping it here? gah, forgot, thx -- To view, visit https://gerrit.osmocom.org/11504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 9 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 21 Jan 2019 17:33:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
