Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helpers ...................................................................... Patch Set 8: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12492/8/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/#/c/12492/8/src/gsm/gsm0808_utils.c@597 PS8, Line 597: * \returns string representation of LCLS or NULL on error */ ignoring earlier review comment. I'm stopping the review right here. -- To view, visit https://gerrit.osmocom.org/12492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3609224c8f3282d667e75f68bc20327e36eb9e6 Gerrit-Change-Number: 12492 Gerrit-PatchSet: 8 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 12:55:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
