Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helpers ...................................................................... Patch Set 12: Code-Review-1 I agree with neels that the general "culture" within osmocom is to use static string buffers as we don't have multi-threaded implementations of this code anyway. So the question is whether or not we should continue that way (whihc I would agree) or we should change the culture to a dynamically allocated culture. -- To view, visit https://gerrit.osmocom.org/12492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3609224c8f3282d667e75f68bc20327e36eb9e6 Gerrit-Change-Number: 12492 Gerrit-PatchSet: 12 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Mon, 04 Feb 2019 13:33:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
