Max has posted comments on this change. ( https://gerrit.osmocom.org/12401 )
Change subject: fix lchan modifications: switch off re-using lchan during assignment ...................................................................... Patch Set 3: Code-Review-1 (2 comments) It seems like this doesn't really fix an issue - it rather works around it by disabling some code. https://gerrit.osmocom.org/#/c/12401/3/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/12401/3/src/osmo-bsc/assignment_fsm.c@345 PS3, Line 345: ------- This looks like something which should belong to issue tracker. Put it into https://osmocom.org/issues/3735 instead? https://gerrit.osmocom.org/#/c/12401/3/src/osmo-bsc/assignment_fsm.c@369 PS3, Line 369: Test scenario: This looks like it belong to TTCN3 instead. I think we should first make TTCN3 test covering call-in-call scenario and than make any significant changes to this. -- To view, visit https://gerrit.osmocom.org/12401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 15:30:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
