Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12401 )
Change subject: fix lchan modifications: switch off re-using lchan during assignment ...................................................................... Patch Set 3: - I have no time to write a test. - It is so obviously broken. - Why it is broken is explained in this patch and its comments. I also found another failure in this code path just now: the assignment FSM does not get terminated in the lchan re-use case, and hence the ASSIGNMENT_END event never gets dispatched. This is completely untested, unneccessary, broken. > why disable instead of removing if the failures around this get fixed, the disabled part still makes sense. It serves as a reminder where to implement channel re-use in the future. Note that https://gerrit.osmocom.org/c/osmo-bsc/+/12625 is a merge conflict with this patch. I will put this one after the other. -- To view, visit https://gerrit.osmocom.org/12401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 16:30:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
