Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 33: (2 comments) https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c@120 PS33, Line 120: static void subscr_conn_toss(struct sgs_connection *sgc, struct vlr_subscr *vsub) (sgc arg is not used) https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c@821 PS33, Line 821: "Receiving uplink unit-data for non-sgs connection -- discarding message!\n"); Is the message being discarded? Not seeing a free nor return -1... -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 33 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Wed, 23 Jan 2019 01:51:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
