osmith has posted comments on this change. ( https://gerrit.osmocom.org/12694 )
Change subject: ttcn3-*-test: don't hardcode /usr/local/bin/ ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12694/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12694/1//COMMIT_MSG@9 PS1, Line 9: Remove hardcoded /usr/local/bin/osmo-* run commands from jenkins.sh. : This caused the *-latest tests to fail, as they have the Osmocom : binaries in /usr/bin instead of /usr/local/bin. : : Adjust Dockerfiles where the default run command was different from the : hardcoded run command in jenkins.sh (e.g. missing config file : parameters). > how are those two seemingly unrelated topics connected to each other? > Shouldn't this be two commits? They are connected, because after removing the hardcoded command from jenkins.sh, it will fall back to the default command in Dockerfile. But you are right, these are two logical changes, made a second commit. https://gerrit.osmocom.org/#/c/12694/1//COMMIT_MSG@17 PS1, Line 17: Related: OS#367 > probably missing a digit, it's long ago since we had three-digit issue > numbers... Oh right, fixed! -- To view, visit https://gerrit.osmocom.org/12694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1427e66028ffd15fed211b2dab5adc37718666 Gerrit-Change-Number: 12694 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 25 Jan 2019 13:23:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
