osmith has posted comments on this change. ( https://gerrit.osmocom.org/12694 )
Change subject: ttcn3-*-test: don't hardcode /usr/local/bin/ ...................................................................... Patch Set 3: (2 comments) New simple and clean patch that just removes /usr/local/bin. https://gerrit.osmocom.org/#/c/12694/2/ttcn3-bts-test/jenkins.sh File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/#/c/12694/2/ttcn3-bts-test/jenkins.sh@a37 PS2, Line 37: > whay are we removing the config file argument, if this commit is fixing the > /usr/local/bin path?!? I had assumed that it would be cleaner to remove the entire run command here, and use the default run command specified in Dockerfile instead. That's why I had deleted the whole line (including the config parameter). But I've realized that the cleanest way to do this is just remove /usr/local/bin from each command in jenkins.sh and modify nothing else. So I've pushed a new patch version, please take another look. https://gerrit.osmocom.org/#/c/12694/3/ttcn3-sip-test/jenkins.sh File ttcn3-sip-test/jenkins.sh: https://gerrit.osmocom.org/#/c/12694/3/ttcn3-sip-test/jenkins.sh@30 PS3, Line 30: -M /data/unix/mncc Vadim noted that -M is invalid for osmo-sip-connector in a related patch, so I've fixed it here: https://gerrit.osmocom.org/#/c/docker-playground/+/12707/ -- To view, visit https://gerrit.osmocom.org/12694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1427e66028ffd15fed211b2dab5adc37718666 Gerrit-Change-Number: 12694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 13:04:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
