Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12706 )
Change subject: Support International Caller ID ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c@783 PS2, Line 783: if (strncmp(call->source, "+", 1) == 0) { > Since you're comparing just a single character you can do it directly like: > […] I'm /pretty/ sure it is initialised, but I'm not 100% sure what that term means here, technically. If we actually got to exec'ing this code and call->source has no value, then something is horribly wrong anyway. -- To view, visit https://gerrit.osmocom.org/12706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe Gerrit-Change-Number: 12706 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 23:58:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
