Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12706 )
Change subject: Support International Caller ID ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@795 PS5, Line 795: osmo_strlcpy OSMO_STRLCPY_ARRAY(mncc.calling.number, call->source +1) https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@798 PS5, Line 798: osmo_strlcpy(mncc.calling.number, call->source, sizeof(mncc.calling.number)); same here. avoids the sizeof, the macro takes care of it. -- To view, visit https://gerrit.osmocom.org/12706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe Gerrit-Change-Number: 12706 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 12:38:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
